Skip to content

Conversation

@virgile-dev
Copy link
Collaborator

@virgile-dev virgile-dev commented Apr 16, 2025

Info message so people fulfill their licencing obligations

@virgile-dev virgile-dev requested a review from lunika April 16, 2025 20:50
@virgile-dev virgile-dev force-pushed the small-readme-fixes branch 2 times, most recently from fd01eb8 to 3f99c2e Compare April 16, 2025 21:01
@virgile-dev virgile-dev enabled auto-merge (squash) April 16, 2025 21:02
@bzg
Copy link
Collaborator

bzg commented Apr 21, 2025

I suggest we stick to the current message until the technical solution is implemented.

@bzg
Copy link
Collaborator

bzg commented Apr 22, 2025

I strongly suggest not to merge this until the technical solution is in place.

@sampaccoud
Copy link
Member

@bzg after close consideration, I choose to merge this PR. The implementation to make the packages optional will be done next week but the current sentence also failed to precisely reflect the current situation: yes there is an incompatibility between our MIT licence and the BlockNote XL AGPL licence, but we discussed with the maintainer and he considers that, as long as the code remains open (whether commercial or not), there is no issue.

Info message so people fulfill their licencing obligations

Signed-off-by: virgile-dev <virgile.deville@beta.gouv.fr>
@bzg
Copy link
Collaborator

bzg commented Apr 22, 2025

If the implementation will be in the code next week, why not wait?

The discussion between @virgile-dev, @lunika and DINUM's legal department led to this conclusion: the warning is needed to inform reusers of their obligations regarding license compliance.

With 11.6K stars and 275 forks, DINUM must be DTRT.

@virgile-dev virgile-dev merged commit cdafe6f into main Apr 22, 2025
18 of 20 checks passed
@virgile-dev virgile-dev deleted the small-readme-fixes branch April 22, 2025 13:57
PanchoutNathan pushed a commit that referenced this pull request Apr 23, 2025
Info message so people fulfill their licencing obligations

Signed-off-by: virgile-deville <virgile.deville@beta.gouv.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants